Can any one tell me how many wrong JS i have in this - pleas

Discuss phpbb and phpbb related stuff here. No support!
Forum rules
This area is for discussion. No support!
All support requests are locked and poster will be banned!
User avatar
themission
BBCoder III
BBCoder III
Posts: 123
Joined: 10 Aug 2011, 20:32
BBCodes: 3
Location: Devon UK

Can any one tell me how many wrong JS i have in this - pleas

Post by themission » 04 Jan 2012, 21:28

Code: Select all

</script>
<script type="text/javascript" src="{T_TEMPLATE_PATH}/styleswitcher.js"></script>
<script type="text/javascript" src="{T_TEMPLATE_PATH}/forum_fn.js"></script>
<script src="{ROOT_PATH}script/jquery-1.7.min.js" type="text/javascript"></script>
<!-- IF (S_TSRAT_ENABLE and S_TS_JSSCROLL) or (S_TSRAT_ENABLE and S_TS_TICKER) -->
<!-- IF S_TS_JSSCROLL and not S_TS_TICKER -->
<script src="{ROOT_PATH}script/jquery.totemticker.min.js" type="text/javascript"></script>
<script type="text/javascript">
// <![CDATA[
$(document).ready(function() {
	$('#vertical-ticker').totemticker({
				row_height	:	'41px',
				max_items   :   3,
				speed       :   {JSSCROLL_SPEED},
				interval    :   {JSSCROLL_INTERVAL},
				<!-- IF TS_JSSCROLL_NAVIGATION -->
				next		:	'#ticker-next',
				previous	:	'#ticker-previous',
				stop		:	'#stop',
				start		:	'#start',
				<!-- ENDIF -->
				mousestop	:	true,
				direction	:	'<!-- IF TS_JSSCROLL_DIRECTION -->down<!-- ELSE -->up<!-- ENDIF -->'
	});
});
// ]]>
</script>
<!-- ELSEIF S_TS_TICKER and not S_TS_JSSCROLL -->
<script src="{ROOT_PATH}script/jquery.newsticker.js" type="text/javascript"></script>
<script type="text/javascript">
// <![CDATA[
$(document).ready(function() {
	$("#news").newsTicker();
});
// ]]>
</script>
<!-- ENDIF -->
<!-- ENDIF -->
<script type="text/javascript" src="{ROOT_PATH}highslide/highslide-full.js"></script>
<link href="{ROOT_PATH}highslide/highslide.css" rel="stylesheet" type="text/css" />
<script type="text/javascript">
// <![CDATA[
hs.graphicsDir = '{ROOT_PATH}highslide/graphics/';
hs.align = 'center';
hs.transitions = ['expand', 'crossfade'];
hs.outlineType = 'rounded-white';
hs.fadeInOut = true;
hs.dimmingOpacity = 0.75;

// Add the controlbar
hs.addSlideshow({
	//slideshowGroup: 'group1',
	interval: 5000,
	repeat: false,
	useControls: true,
	fixedControls: 'fit',
	overlayOptions: {
		opacity: 0.75,
		position: 'bottom center',
		hideOnMouseOut: true
	}
});
// ]]>
</script>
<script type="text/javascript" src="{T_TEMPLATE_PATH}/tooltip.js"></script>
<link href="{T_THEME_PATH}/print.css" rel="stylesheet" type="text/css" media="print" title="printonly" />
<link href="{T_STYLESHEET_LINK}" rel="stylesheet" type="text/css" media="screen, projection" />

<link href="{T_THEME_PATH}/normal.css" rel="stylesheet" type="text/css" title="A" />
<link href="{T_THEME_PATH}/medium.css" rel="alternate stylesheet" type="text/css" title="A+" />
<link href="{T_THEME_PATH}/large.css" rel="alternate stylesheet" type="text/css" title="A++" />

<!-- IF S_CONTENT_DIRECTION eq 'rtl' -->
	<link href="{T_THEME_PATH}/bidi.css" rel="stylesheet" type="text/css" media="screen, projection" />
<!-- ENDIF -->
<!-- IF S_IN_ARCADE -->
	<link href="{T_THEME_PATH}/arcade.css" rel="stylesheet" type="text/css" media="screen, projection" />
<!-- ENDIF -->
<script type="text/javascript" src="{ROOT_PATH}js/leaderboard/overlib.js"></script>
<script type="text/javascript" src="{ROOT_PATH}js/leaderboard/leaderboard.js"></script>
    <!--phpBB Pretty Sociable by Slash & Stoker www.wiizard.it www.phpbb3bbcodes.com-->

    <!-- IF SCRIPT_NAME == "viewtopic" or SCRIPT_NAME == "viewforum" -->
    <script type="text/javascript" src="{ROOT_PATH}script/prettySociable/js/jquery.prettySociable.js"></script>
    <!-- ENDIF -->

    <script type="text/javascript">
    // <![CDATA[
    $(document).ready(function(){
       <!-- IF SCRIPT_NAME == "viewtopic" or SCRIPT_NAME == "viewforum" -->
       $.prettySociable();
       <!-- ENDIF -->   
    });
    // ]]>
    </script>
    <!--[if lte IE 6]><script src="{ROOT_PATH}script/prettySociable/js/DD_belatedPNG.js" type="text/javascript"></script><![endif]-->

    <!-- IF SCRIPT_NAME == "viewtopic" or SCRIPT_NAME == "viewforum" -->
    <link rel="stylesheet" href="{ROOT_PATH}script/prettySociable/css/prettySociable.css" type="text/css" media="screen" />
    <!-- ENDIF -->

    <!--phpBB Pretty Sociable by Slash & Stoker www.wiizard.it www.phpbb3bbcodes.com-->
<!-- IF S_MCHAT_ENABLE and (S_MCHAT_ON_INDEX or U_MCHAT) -->
<script type="text/javascript" src="{ROOT_PATH}mchat/jquery.titlealert.min.js"></script>
<!-- ENDIF -->
<script type="text/javascript" src="{ROOT_PATH}script/collapse/jquery.collapse.js"></script>
<!-- // START jQuery Live Signature Character Counter // -->
<!-- IF (SCRIPT_NAME == 'ucp') -->
<script type="text/javascript">
// <![CDATA[
	if (window.jQuery === undefined) {
		document.write(unescape('%3Cscript src="{ROOT_PATH}script/jquery-latest.min.js" type="text/javascript"%3E%3C/script%3E'));
	}
// ]]>
</script>
<script type="text/javascript" src="{ROOT_PATH}script/jquery.maxlength.min.js"></script>
<!-- ENDIF -->
<!-- // END jQuery Live Signature Character Counter // -->

</head>
Am trying to get the collapse forums etc - i know theres a lot of mins etc but doing my head in :o

EDIT = what do i need to delete or keep ?


User avatar
Vox Populi
BBCoder III
BBCoder III
Posts: 135
Joined: 27 Jul 2011, 13:44
BBCodes: 51
Favourite BBCode: YouTube
Favourite MOD: mChat, Welcome on Index
Location: Index,WA

Can any one tell me how many wrong JS i have in this - pleas

Post by Vox Populi » 04 Jan 2012, 21:32

Not all java scripts play well with each other. You need to work backwards and remove the last js and keep going from there if you are having problems. It's not that hard to track down java problems.
Be who you are and say what you feel.
Those who mind don't matter.
Those who matter don't mind.
- Dr. Seuss

User avatar
doktornotor
BBCoder IV
BBCoder IV
Posts: 167
Joined: 14 Sep 2011, 21:20
BBCodes: 30
Favourite MOD: Thanks for Posts

Can any one tell me how many wrong JS i have in this - pleas

Post by doktornotor » 04 Jan 2012, 21:44

Looks like you have cut off some at the top? :lol:

Cannot see something terribly wrong there off hand, those mutiple $(document).ready(function(){}; instances should be combined all into one... arguably these also belong rather in overall_footer.html. But as said above, with so much JS there is always potential for conflict.
Support requests via PM go straight to /dev/null!

User avatar
themission
BBCoder III
BBCoder III
Posts: 123
Joined: 10 Aug 2011, 20:32
BBCodes: 3
Location: Devon UK

Can any one tell me how many wrong JS i have in this - pleas

Post by themission » 05 Jan 2012, 09:01

Ok thanks, will have a fiddle with it - its not my main theme so no worries ;)

User avatar
RMcGirr83
BBCoder III
BBCoder III
Posts: 104
Joined: 08 Mar 2010, 11:17
Favourite MOD: mChat

Can any one tell me how many wrong JS i have in this - pleas

Post by RMcGirr83 » 07 Jan 2012, 13:08

I see that you have all this wonderful jQuery add-ons, yet I don't see any link to the jQuery library.


User avatar
doktornotor
BBCoder IV
BBCoder IV
Posts: 167
Joined: 14 Sep 2011, 21:20
BBCodes: 30
Favourite MOD: Thanks for Posts

Can any one tell me how many wrong JS i have in this - pleas

Post by doktornotor » 07 Jan 2012, 14:36

RMcGirr83 wrote:I see that you have all this wonderful jQuery add-ons, yet I don't see any link to the jQuery library.

Code: Select all

<script src="{ROOT_PATH}script/jquery-1.7.min.js" type="text/javascript"></script>
almost at the very top of the mess :D
Support requests via PM go straight to /dev/null!